Add box_area_center and box_iou_center functions for cxcywh format with tests
#8992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8992
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
reviewed
May 1, 2025
| @@ -291,6 +291,25 @@ def box_area(boxes: Tensor) -> Tensor: | |||
| return (boxes[:, 2] - boxes[:, 0]) * (boxes[:, 3] - boxes[:, 1]) | |||
|
|
|||
|
|
|||
| def box_area_center(boxes: Tensor) -> Tensor: | |||
There was a problem hiding this comment.
Thanks a lot for the PR and for the benchmarks @alperenunlu !
I agree with @AntoineSimoulin 's suggestion in #8961 (comment) to not expose the new _center() functions, and instead just add a new fmt (or in_fmt) parameter to the existing box_area() and box_iou() functions.
This will reduce surface area of the API, so it'll be easier to find for users, and easier for us to maintain as well!
For the rest I will let @AntoineSimoulin take a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #8961
This pull request introduces new utility functions for handling bounding boxes and adds corresponding tests. The main changes include the addition of
box_area_centerandbox_iou_centerfunctions, as well as comprehensive tests to ensure their correctness.New utility functions:
torchvision/ops/boxes.py: Addedbox_area_centerfunction to compute the area of bounding boxes specified by their center coordinates.torchvision/ops/boxes.py: Addedbox_iou_centerfunction to compute the intersection-over-union (IoU) for bounding boxes specified by their center coordinates.Documentation updates:
docs/source/ops.rst: Updated the documentation to includebox_area_centerandbox_iou_center.Test additions:
test/test_ops.py: AddedTestBoxAreaCenterclass with tests forbox_area_centerfunction.test/test_ops.py: AddedTestBoxIouCenterclass with tests forbox_iou_centerfunction.Module initialization:
torchvision/ops/__init__.py: Updated the module initialization to includebox_area_centerandbox_iou_center[1] [2].