Cross compile guard #3486
Open
Cross compile guard #3486
+79
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
narendasan
reviewed
Apr 25, 2025
|
|
||
| def check_cross_compile_trt_win_lib(): | ||
| if sys.platform.startswith("linux"): | ||
| LINUX_PATHS = ["/usr/local/cuda-12.8/lib64", "/usr/lib", "/usr/lib64"] |
There was a problem hiding this comment.
I dont think this works generically, there needs to be a way to see of the library has been loaded aready
There was a problem hiding this comment.
I took this code snippet from
py/torch_tensorrt/__init__.py where we check the tensorrt libs while importing torch_tensorrt. Since this is included in features I am putting this code snippet in _utils, where it checks if the _win*.so is present or not to be loaded via ctypes.CDLL ( can use ctypes.cdll.LoadLibrary() too). What is your thoughts on how to do this
apbose
force-pushed
the
cross_compile_guard
branch
from
9a4f681 to
ed8d559
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses the following-