feat(RHOAIENG-25241): disable ray usage metrics by default

[kryanbeane]

Issue link

What changes have been made

Made RAY_USAGE_STATS_ENABLED default to = 0, which == disabled. Added unit tests to ensure enabledment and disablement. Also did manual testing and verified that a deployed custom build image has a default env var of RAY_USAGE_STATS_ENABLED = 0 on both head and worker pods

I verified that the env was present on the cluster

I also deployed a custom codeflare-sdk build on cluster and verified that /tmp/ray/session_xxx/usage_stats.json file does not exist. This is where ray temp writes usage stats to on the head.

Verification steps

• Build custom image of codeflare-sdk (which goes to .dist folder)
• Drag that to jupyter notebook in your cluster or locally, use it to install codeflare in notebook
• Create a cluster (don't specify envs) and ensure head and workers have the env in place with a value of 0

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chipspeak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (028d0d5) to head (51f594a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   92.45%   92.47%   +0.01%     
==========================================
  Files          24       24              
  Lines        1419     1421       +2     
==========================================
+ Hits         1312     1314       +2     
  Misses        107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kryanbeane]

hey @szaher, I looked at the method you mentioned, to put RAY_USAGE_STATS_ENABLED in the ray cluster resource, and want to get your thoughts on this: I checked back on the meeting notes (ty gemini) and we had mentioned we want to let customers enable sending usage stats if they want. And so my head is going "what's easier for user to enable this if they want to". If we enable in the way this PR is, they just need to edit the ClusterConfiguration spec with the below :

envs = {
    "RAY_USAGE_STATS_ENABLED": "1"
}

If we did it the way you mentioned, they'd need to go and manually edit the RayCluster CR and add the env (I think). Although, since we would be hard coding the env in a python dict, wouldn't it get overwritten to be disabled again by codeflare sdk? Maybe I'm wrong tho, wdyt?