Skip to content

[WIP] Adding datasets to dependencies #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Fiona-Waters
Copy link
Contributor

Issue link

RHOAIENG-6475

What changes have been made

When running the training job in the basic_interactive demo notebook the following error is encountered:

ModuleNotFoundError: No module named 'datasets'

This dependency has been added to the pyproject.toml file.

Verification steps

  • In a jupyter notebook install codeflare SDK from this PR
git clone https://github.com/Fiona-Waters/codeflare-sdk.git -b add-datasets
pip install poetry
poetry install
  • Restart the kernal and run the basic_interactive demo from start to finish and ensure you do not see the error.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from fiona-waters. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fiona-Waters Fiona-Waters changed the title Adding datasets to dependencies [WIP] Adding datasets to dependencies Apr 25, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@Fiona-Waters
Copy link
Contributor Author

Closing in favour of #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant