-
Notifications
You must be signed in to change notification settings - Fork 53
Fix codeflare-sdk python e2e tests to pick timeout #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codeflare-sdk python e2e tests to pick timeout #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running: When running: |
I am able to run both unit test and e2e test by installing with steps
by declaring in pytest liek below its not picking timeout |
/lgtm thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors down to local set up. When following instructions in readme to run tests everything works as expected.
/approve
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fiona-Waters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
closes https://issues.redhat.com/browse/RHOAIENG-4674
What changes have been made
Adjusted pytest section in pyproject.toml file to use timeout option for e2e tests
Verification steps
Check while running e2e tests timeout is with default
timeout: 900.0s
Checks