Add AMD GPU test for ray clusters #670
Conversation
| PIP_TRUSTED_HOST: "` + GetPipTrustedHost() + `" | ||
| ACCELERATOR: "` + accelerator + `" | ||
| `, | ||
| RuntimeEnvYAML: fmt.Sprintf(` |
There was a problem hiding this comment.
It is also possible to generate the yaml from struct - i.e. using https://pkg.go.dev/sigs.k8s.io/yaml#section-readme.
Though, as this yaml handling is relevant just for this one place - it is ok to keep current implementation.
|
|
||
| if accelerator.IsGpu() { | ||
| cqSpec.ResourceGroups[0].Flavors[0].Resources[2].NominalQuota = resource.MustParse("1") | ||
| if accelerator.ResourceLabel == "amd.com/gpu" { |
|
Please adjust https://github.com/project-codeflare/codeflare-operator/blob/main/.github/workflows/e2e_tests.yaml#L92 to skip both CPU and AMD tests. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiripetrlik, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a96625a
into
project-codeflare:main
Issue link
Closes RHOAIENG-11047
What changes have been made
numberofGpusparameter from createClusterQueue, constructRayCluster and constructRayJob methodVerification steps
Manually run the tests on OCP with NVIDIA and AMD gpus
Checks