Create RayCluster ValidatingWebhook #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianZaccaria
force-pushed
the
validating-webhook
branch
from
5524dff to
103c61f
Compare
KPostOffice
reviewed
Apr 17, 2024
astefanutti
reviewed
Apr 18, 2024
ChristianZaccaria
force-pushed
the
validating-webhook
branch
2 times, most recently
from
cf264f8 to
7b6967a
Compare
astefanutti
reviewed
Apr 18, 2024
ChristianZaccaria
force-pushed
the
validating-webhook
branch
2 times, most recently
from
eed9ece to
fa02948
Compare
ChristianZaccaria
force-pushed
the
validating-webhook
branch
from
fa02948 to
2485096
Compare
astefanutti
reviewed
Apr 18, 2024
astefanutti
reviewed
Apr 18, 2024
astefanutti
reviewed
Apr 18, 2024
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2b885eb
into
project-codeflare:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Jira: https://issues.redhat.com/browse/RHOAIENG-5116
What changes have been made
Verification steps
With the CFO running, attempt to create a RayCluster either from a notebook or locally. The validating webhook will reject creation if the enableIngress field is unset or is true.
Checks