-
-
Notifications
You must be signed in to change notification settings - Fork 64
Add Python code for couple your code
section
#523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f5e0cac
to
80aabc0
Compare
@uekerman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in principle. No need to also cover inline code. The code blocks are enough. And not need to bring the docstrings.
Be careful with details. The code should really run. Maybe test with a dummy on the side to be completely sure.
Where do the css changes come from? I am not saying that they don't make sense, I only want to understand better. Could you maybe add screenshots before and after?
I did not try to build the website.
You also pushed to #211. No need to update both. You could close #211 in favor of this one.
pages/docs/couple-your-code/couple-your-code-steering-methods.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-steering-methods.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-mesh-and-data-access.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-mesh-and-data-access.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-mesh-and-data-access.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-mesh-and-data-access.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-mesh-and-data-access.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-mesh-and-data-access.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-mesh-and-data-access.md
Outdated
Show resolved
Hide resolved
80aabc0
to
df9b3cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. A few minor tweaks and fixes below.
Good that you also caught a few missing v2-v3 updates as well 👍
I did not try building the website. Did you check that everything looks good?
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-implicit-coupling.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-implicit-coupling.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-time-step-sizes.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-time-step-sizes.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-time-step-sizes.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-time-step-sizes.md
Outdated
Show resolved
Hide resolved
…ghlight association between tab headers and tab content when printed, issue precice#211
df9b3cb
to
31e934a
Compare
couple your code
sectioncouple your code
section
In my taste, the vertical margins before and after the code are a bit large. Could we decrease those? |
This PR implements the discussions of #211.
Add Python code examples for the
couple your code
section using nav tabs.