Revert "Fix maxp table" #104
Conversation
There was a problem hiding this comment.
Yes, this fixes the Adobe Reader warnings "Cannot extract embedded font xxx" when viewing a PDF generated with prawn 2.4.0
I am well aware that reverting this change to the encode function is not a real fix, but the current encode function just does not work so we better get back to the old function that does work.
|
Thank you for developing such a wonderful gem. Is there any issue preventing this PR from being merged? I’m experiencing the same issue in my environment, and I would love to update the TTFunk version if this could be merged. It would be greatly appreciated. |
|
@hayaokimura Lack of time. |
|
@pointlessone This looks like a reasonable revert of this function. Since we know this function worked in ttfunk 1.7.0, and if we don't anticipate any knock-on effects from it, can we merge and release this as 1.8.1? I will run this in production and see how it works. |
|
@pointlessone I'm running this in production for a wide range of PDF types and fonts/languages with no issues reported. I think it's safe to merge--certainly safer than the alternative of having people suffer this bug when they upgrade! |
|
@johnnyshields Have you tried #106? |
|
@pointlessone not yet, didn't see that one, thanks for pointing it out. I will try it this week and see if we get any reports of issues. FYI my product (TableCheck) is used in 13,000 restaurants, at least ~30% of whom are generating PDFs daily for their guestlist. We also do PDF e-receipts for online payments as well. |
|
@pointlessone As commented in #106, I've tested #106 and it looks good. If it could be released as a tiny version I'm sure many people would appreciate it. |
With ttfunk v1.8.0, using Japanese true type fonts such as GenShin Gothic resulted in creating PDF files that could not be loaded in Acrobat Reader. The cause seems to be with maxp, and by applying a monkey patch to make the code equivalent to ttfunk v1.7.0, normal PDFs were able to be generated. So I would like to revert the relevant code. If I revert the pull request #78, the ChangeLog and others would also be reverted, so I reverted only the code to be the same as ttfunk v1.7.0. Issue #102 likely has the same root cause.