-
-
Notifications
You must be signed in to change notification settings - Fork 183
feat: update go-jose to resolve x/crypto vuln #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
go.mod
Outdated
go 1.23.0 | ||
|
||
toolchain go1.24.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go 1.23.0 | |
toolchain go1.24.2 | |
go 1.22 |
should we revert that for now or was this change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im having a look in more depth have a linter issue about going back to 1.22, do you even use go-jose? go mod tidy suggests you don't.
edit: i see the one file where its used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the output when you try to upgrade it.
$ go get -u github.com/go-jose/go-jose/v3
go: upgraded go 1.22.0 => 1.23.0
go: upgraded toolchain go1.23.0 => go1.24.2
go: upgraded golang.org/x/crypto v0.19.0 => v0.37.0
it seems intentional? ( possibly because im on 1.24.2, the toolchain can be rolled back ).
im happy to close this if you want to handle updating it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did a new push with what i think is minimal. i haven't had to deal with things that possibly require a go version change. but might make sense if upgrading x/crypto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
playwright-go only uses the json library in go-jose. The difference from the go standard library is https://github.com/go-jose/go-jose/tree/main/json#safe-json.
Not affected by the security vulnerabilities.
Anyway, I updated its version in #540.
ok so a quick summary, the indirect in the go mod would get cleaned up with a go mod tidy, the docs i found about the go toolchain suggest requiring a higher level of something a downstream packages uses will default to the higher version provided they are the same major version which they are. |
this resolves a CVE that popped up in one of our scans.
GHSA-v778-237x-gjrc
i was unable to run the tests to verify it had no impact.