Skip to content

Unify main graph icons #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Unify main graph icons #5339

merged 1 commit into from
May 7, 2025

Conversation

apata
Copy link
Contributor

@apata apata commented Apr 16, 2025

Changes

  • Fixes alignment between main graph icons / buttons
  • Gives all of them a similar focus ring
  • Gives the export button a tooltip
  • Unifies 2 separate and visually different ( i ) icons about sampling and imports into a single one that displays either or both messages.

With these changes:
Screenshot 2025-05-07 at 11 20 22
Screenshot 2025-05-07 at 11 20 29
Screenshot 2025-05-07 at 11 20 34
Screenshot 2025-05-07 at 11 20 42
Screenshot 2025-05-07 at 11 20 48

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

@apata apata added the preview label Apr 16, 2025
Copy link

Preview environment👷🏼‍♀️🏗️
PR-5339

@apata apata force-pushed the update-headless-ui branch from c7edb13 to 4013bab Compare April 17, 2025 10:34
@apata apata force-pushed the update-graph-icons branch from 81add0c to 6ec6f98 Compare April 17, 2025 10:37
@apata apata force-pushed the update-headless-ui branch 2 times, most recently from adffd56 to 7a9bddc Compare April 25, 2025 06:27
@apata apata force-pushed the update-headless-ui branch from 5f46313 to 7191eb9 Compare May 7, 2025 05:15
@apata apata force-pushed the update-graph-icons branch from 6ec6f98 to 44d6410 Compare May 7, 2025 08:12
@apata apata changed the base branch from update-headless-ui to master May 7, 2025 08:12
@apata apata force-pushed the update-graph-icons branch from 44d6410 to 2a69b42 Compare May 7, 2025 08:21
@apata apata requested a review from a team May 7, 2025 08:22
@apata apata added this pull request to the merge queue May 7, 2025
Merged via the queue into master with commit 34ae684 May 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants