Skip to content

#376 (and #386): Lay_...() has correct orientation in combination with LAYOUT_LANDSCAPE() (and theme documentation is updated) #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2025

Conversation

kirchsth
Copy link
Member

@kirchsth kirchsth commented Apr 6, 2025

Important

PlantUML v2.12.0: Layout could be changed based on bugfix.
If LAYOUT_LANDSCAPE() is combined with Lay_*() calls then the elements are correct positioned based on the new implementation.
The old implementation swapped up<->left and down<->right (details see issue 376).
The old behavior can be re-activated with !NO_LAY_ROTATE=1. Details see Compatibility mode NO_LAY_ROTATE=1.

  • Problem with Theme colors #386 theme has to be before includes; theme sample is added
    • extend Theme.md documentation: !theme has to be before !include
    • add a container diagram with a theme to C4CoreDiagrams(.md)

Both changes can be checked via my branch.

BR
Helmut

@kirchsth kirchsth changed the title #376 (and #386): (additional update theme docu) #376 (and #386): Lay_...() has correct orientation in combination with LAYOUT_LANDSCAPE() (and theme documentation is updated) Apr 6, 2025
@kirchsth kirchsth added this to the v2.12.0 milestone Apr 6, 2025
@kirchsth kirchsth requested a review from Potherca April 6, 2025 15:09
@kirchsth kirchsth merged commit 3643f58 into plantuml-stdlib:master May 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with Theme colors LAYOUT_LANDSCAPE() rotates the Lay_* directions too
1 participant