Skip to content

Microoptimize AssertRuleHelper. #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

mad-briller
Copy link
Contributor

minor micro-opts to AssertRuleHelper

this static method is called multiple times for every ast node analysed currently due to the rules that use it specifying NodeAbstract as their node type

@mad-briller
Copy link
Contributor Author

not sure why the actions are failing, just says "failed to setup phpX.X"

@ondrejmirtes
Copy link
Member

Yeah, that's not your fault. Thank you!

@ondrejmirtes ondrejmirtes merged commit d8bdab0 into phpstan:1.1.x May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants