Skip to content

Fixed false positive when covering a global function. #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

mad-briller
Copy link
Contributor

@mad-briller mad-briller commented Feb 28, 2023

Previously this case wasn't tested and was overlooked as phpstan test data files are namespaced, but this cropped up today during rollout of the rules and so i've had to @covers a php built-in to cover the case in a test

also moved the "doesn't specify anything" test up in the code as it's a fail-fast path, dunno why i put it where i did in the first place, time pressure probably

thanks for your time

@ondrejmirtes ondrejmirtes merged commit 34ee324 into phpstan:1.1.x Feb 28, 2023
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants