[GR-62284] Introduce RegistrationCondition and TypeReachabilityCondition #11139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
changed the title
graalvmbot
force-pushed
the
mm/GR-62284-configuration-condition-api-changes
branch
from
d63d66f to
1fcebfd
Compare
ConfigurationCondition is divided into RegistrationCondition(API) and TypeReachabilityCondition(implementation). Replaced all usages of ConfigurationCondition.
graalvmbot
force-pushed
the
mm/GR-62284-configuration-condition-api-changes
branch
from
1fcebfd to
535cf93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we don't have public API for user to create conditions that are used in metadata registration.
In this PR we are dividing ConfigurationCondition into InclusionCondition(Public API) and TypeCondition(Internal implementation). TypeCondition is class that represents both TypeReached and TypeReachable (legacy) conditions.
All usage of ConfigurationCondition is removed.
Review entry points: InclusionCondition, TypeCondition.