NO-JIRA: Improve unexpected reboot test output #29668
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test output today is pretty confusing, times are not formatted as they were intended due to the use of slices. This change formats the timestamps to be human readable in output, improves a couple variable names, and logs the boots for each node in chronological order instead of reverse.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: dab9f95
New tests seen in this PR at sha: dab9f95
|
|
/test e2e-metal-ipi-ovn e2e-metal-ipi-virtualmedia e2e-metal-ipi-ovn-dualstack-local-gateway |
|
@dgoodwin It looks good. Did you have a chance to test and see if the output is really what you expect? |
MaysaMacedo
reviewed
Apr 10, 2025
| @@ -137,37 +145,40 @@ var _ = g.Describe("[sig-node] Managed cluster", func() { | |||
| allTimelineEvents := []bootTimelineEntry{} | |||
| allTimelineEvents = append(allTimelineEvents, nodeBoots...) | |||
| allTimelineEvents = append(allTimelineEvents, nodeReboots...) | |||
|
|
|||
| e2e.Logf("timeline events for %q\n%v", node.Name, formatTimeline(allTimelineEvents)) | |||
|
|
|||
| sort.Sort(sort.Reverse(byTime(allTimelineEvents))) | |||
There was a problem hiding this comment.
will this still make the output to be reversed? Like newer first in the list?
There was a problem hiding this comment.
Only in the stdout log, not the actual test output. Maybe I should leave this be so it's the same for both but its nice to see the list in chronological order in the stdout
|
Unfortunately this test is too rare a failure to reproduce in the PR, so we'd have to push it into the wild and wait. |
|
Actually I can add a bogus failure and make it fail, I'll try that |
dgoodwin
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@dgoodwin: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dgoodwin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 5beff6c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test output today is pretty confusing, times are not formatted as
they were intended due to the use of slices. This change formats the
timestamps to be human readable in output, improves a couple variable
names, and logs the boots for each node in chronological order instead
of reverse.
Old output: