Skip to content

OCPBUGS-54771: Component Readiness: [Networking / ovn-kubernetes] [EgressFirewall] test regressed #29661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

OCPBUGS-54771: Component Readiness: [Networking / ovn-kubernetes] [EgressFirewall] test regressed #29661

merged 2 commits into from
Apr 22, 2025

Conversation

germanparente
Copy link

Fix egress firewall tests by updating the URL from docs.redhat.com to redhat.com

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2025
@openshift-ci-robot
Copy link

@germanparente: This pull request references Jira Issue OCPBUGS-54771, which is invalid:

  • expected dependent Jira Issue OCPBUGS-54770 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix egress firewall tests by updating the URL from docs.redhat.com to redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bparees and danwinship April 9, 2025 13:40
@germanparente
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2025
arkadeepsen
arkadeepsen reviewed Apr 9, 2025
View reviewed changes
test/extended/networking/egress_firewall.go Outdated
@@ -72,7 +72,7 @@ var _ = g.Describe("[sig-network][Feature:EgressFirewall]", func() {
_, err = noegFwoc.Run("exec").Args(pod, "--", "ping", "-c", "1", "1.1.1.1").Output()
expectNoError(err)
}
_, err = noegFwoc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m3", "https://docs.openshift.com").Output()
_, err = noegFwoc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m3", "https://docs.redhat.com").Output()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to redhat.com instead of docs.redhat.com. The issue will not be resolved with docs.redhat.com.

@germanparente germanparente changed the title OCPBUGS-54771: Fix egress firewall tests by updating the URL from doc… OCPBUGS-54771: Component Readiness: [Networking / ovn-kubernetes] [EgressFirewall] test regressed Apr 9, 2025
@germanparente
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2025 •
edited
Loading

@germanparente: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn 94e1468 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node 94e1468 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-rt-upgrade 94e1468 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-gcp-csi 94e1468 link false /test e2e-gcp-csi
ci/prow/e2e-metal-ipi-ovn-ipv6 94e1468 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-upgrade 94e1468 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-csi 94e1468 link false /test e2e-aws-csi
ci/prow/e2e-agnostic-ovn-cmd 94e1468 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial 94e1468 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@germanparente
Copy link
Author

/retest-required

@arkadeepsen
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 21, 2025
@openshift-ci-robot
Copy link

@arkadeepsen: This pull request references Jira Issue OCPBUGS-54771, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-54770 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-54770 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter April 21, 2025 06:01
@sosiouxme
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@jupierce jupierce added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Apr 22, 2025
@neisw
Copy link
Contributor

neisw commented Apr 22, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente, neisw, sosiouxme
Once this PR has been reviewed and has the lgtm label, please ask for approval from dgoodwin. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neisw
Copy link
Contributor

neisw commented Apr 22, 2025

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7f472fe into openshift:release-4.13 Apr 22, 2025
13 of 22 checks passed
@openshift-ci-robot
Copy link

@germanparente: Jira Issue OCPBUGS-54771: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54771 has been moved to the MODIFIED state.

In response to this:

Fix egress firewall tests by updating the URL from docs.redhat.com to redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.13.0-202504221833.p0.g7f472fe.assembly.stream.el8.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2025-04-22-232359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadeepsen arkadeepsen arkadeepsen left review comments

@bparees bparees Awaiting requested review from bparees

@danwinship danwinship Awaiting requested review from danwinship

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@sosiouxme sosiouxme

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@kasturinarra kasturinarra

@Moebasim Moebasim

@jadhaj jadhaj

@pamoedom pamoedom

@prietyc123 prietyc123

@gangwgr gangwgr

@prabhapa prabhapa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.