Skip to content

Fix prepare release bugs #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix prepare release bugs #1664

wants to merge 2 commits into from

Conversation

ashwindasr
Copy link
Contributor

No description provided.

@ashwindasr
Copy link
Contributor Author

/hold

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2025
@ashwindasr ashwindasr force-pushed the fix-preprare-release branch from d32d667 to b6f34f2 Compare June 2, 2025 15:08
@ashwindasr ashwindasr changed the title fix missing patch Fix prepare release bugs Jun 2, 2025
thegreyd
thegreyd reviewed Jun 2, 2025
View reviewed changes
pyartcd/pyartcd/pipelines/prepare_release.py
@@ -314,7 +314,10 @@ async def run(self):
self.pre_release = True

# Remove all builds from the metadata advisory
await self.remove_builds_all(advisories["metadata"])
try:
Copy link
Contributor

@thegreyd thegreyd Jun 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of try-catch, would like a if 'metadata' in advisories: drop builds

thegreyd
thegreyd reviewed Jun 2, 2025
View reviewed changes
elliott/elliottlib/cli/create_cli.py
_, minor, patch = runtime.get_major_minor_patch()

if runtime.assembly_type is AssemblyTypes.STANDARD:
_, minor, patch = runtime.get_major_minor_patch()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this works, get_major_minor_patch can learn to handle all assembly types. for preview/candidate assembly, patch should just be "0", and i think for all other custom assembly types as well.

@ashwindasr ashwindasr force-pushed the fix-preprare-release branch from d97421f to 0329619 Compare June 3, 2025 14:25
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 0329619 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreyd thegreyd thegreyd left review comments

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwindasr @thegreyd