Rename test modules to not collide #1639
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thegreyd
force-pushed
the
test_setup_tweaks
branch
from
47e28c5 to
77ce0d5
Compare
thegreyd
added
the
tide/merge-method-squash
|
@thegreyd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I like the idea, tried the PR out but running |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -22,15 +22,15 @@ | |||
| long_description=open('README.md').read(), | |||
| url="https://github.com/openshift-eng/art-tools/tree/main/doozer", | |||
| license="Apache License, Version 2.0", | |||
| packages=find_packages(exclude=["tests", "tests.*", "tests_functional", "tests_functional.*"]), | |||
| packages=find_packages(exclude=["tests.*"]), | |||
There was a problem hiding this comment.
This should be
| packages=find_packages(exclude=["tests.*"]), | |
| packages=find_packages(exclude=["tests_doozer", "tests_doozer.*", "tests_functional_doozer", "tests_functional_doozer.*"]), |
There was a problem hiding this comment.
Thinking we need similar changes for elliott and pyartcd.
When working in art-tools repo/dir as a whole, test discovery with pytest does not work correctly,
because of
testsmodule name collision.pytest --co- this stumps IDEs/extensions/workflows that rely on pytest discovery in the folder.To get around this, rename test modules to align with their parent module, e.g.
tests_doozeretc.With this change
pytest --coandpytest .in root dir should be green