RHOAIENG-24684: fix(jupyter/utils/addon) fix vertical centering of the PatternFly spinner #1029
Conversation
…e PatternFly spinner
After we switched to the css without global css reset, we no longer have the rule
```
:where(html, body) {
height: 100%;
}
```
present, and it causes the spinner to be tucked to the top edge of screen.
I've checked that setting this does not visibly change how JupyterLab (with TensorBoard open) displays.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest rocm-jupyter-pytorch-ubi9-python-3-11-on-pull-request |
This comment was marked as outdated.
This comment was marked as outdated.
|
Okay, thank you for this. In general, this is LGTM. I have couple of questions:
I'll give the lgtm, but I would rather see these questions above answered first. /lgtm |
|
I guess I can open special Jira just for this: https://issues.redhat.com/browse/RHOAIENG-24684 this has no impact on the tree shaking |
jiridanek
changed the title
…e PatternFly spinner (#1029) After we switched to the css without global css reset, we no longer have the rule ``` :where(html, body) { height: 100%; } ``` present, and it causes the spinner to be tucked to the top edge of screen. I've checked that setting this does not visibly change how JupyterLab (with TensorBoard open) displays.
https://issues.redhat.com/browse/RHOAIENG-24684
Follows up on
Description
After we switched to the css without global css reset, we no longer have the rule
present, and it causes the spinner to be tucked to the top edge of screen.
How Has This Been Tested?
Played with it a while.
I've checked that setting this does not visibly change how JupyterLab (with TensorBoard open) displays.
Merge criteria: