Skip to content

NO-JIRA: docs: update outdated internal docs after the buildchain refactoring #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

jiridanek
Copy link
Member

Description

This commit updates internal documentation to reflect changes from a recent buildchain refactoring. It simplifies the explanation of how shared files are incorporated into JupyterLab workbenches. A comment regarding potential duplicates in a script was also removed, indicating it's no longer relevant after the refactoring.

How Has This Been Tested?

Asked AI to

Find errors in the commit: "NO-JIRA: docs: update outdated internal docs after the buildchain refactoring"

and it came back with nothing.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek jiridanek requested a review from caponetto April 25, 2025 08:00
@openshift-ci openshift-ci bot requested review from andyatmiami and atheo89 April 25, 2025 08:00
@openshift-ci openshift-ci bot added the size/xs label Apr 25, 2025
@jstourac
Copy link
Member

/lgtm

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

👍

Copy link
Contributor

openshift-ci bot commented May 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 1, 2025
@jiridanek jiridanek merged commit e7d93ce into opendatahub-io:main May 6, 2025
31 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants