Skip to content

add lang:bn to component label map #7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 4, 2025

I think we missed this one.

Signed-off-by: svrnm <sneumann@causely.ai>
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that I see lang:bn in the label list, but you're right, it's not in this file.
Screenshot 2025-06-04 at 2 09 58 PM

@chalin
Copy link
Contributor

chalin commented Jun 4, 2025

It is my understanding that if one adds it to the file, it'll show up in the web i/f, but not the other way around.

@chalin chalin added this pull request to the merge queue Jun 4, 2025
Merged via the queue into open-telemetry:main with commit dcd079d Jun 4, 2025
19 checks passed
@tiffany76
Copy link
Contributor

It is my understanding that if one adds it to the file, it'll show up in the web i/f, but not the other way around.

For my own understanding, why do you think I could already see it in the GitHub UI before this PR was merged?

@chalin
Copy link
Contributor

chalin commented Jun 5, 2025

Because someone must have added the label from the web UI (without first updating the file). In such a case, the web UI change doesn't propagate to the file (since that would require a repo commit / PR).

The implication is this behavior is: if changes are made via the web UI, and later the file is update, then web UI changes will be lost unless they are also encoded in the file.

@tiffany76
Copy link
Contributor

Got it. Thanks for explaining!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants