F08: refactor templates #13202
Merged
F08: refactor templates #13202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hppritcha
force-pushed
the
refactor_f08_templates
branch
from
9276561 to
717d5f9
Compare
|
@devreal when you get a chance. |
hppritcha
force-pushed
the
refactor_f08_templates
branch
from
717d5f9 to
a80f1a4
Compare
devreal
reviewed
Apr 30, 2025
| @@ -26,6 +26,7 @@ | |||
| #include "ompi/datatype/ompi_datatype.h" | |||
| #include "ompi/errhandler/errhandler.h" | |||
| #include "ompi/mpi/fortran/base/fint_2_int.h" | |||
| #include "bigcount.h" | |||
There was a problem hiding this comment.
Will this work on out-of-tree builds or should that be?
Suggested change
| #include "bigcount.h" | |
| #include "ompi/mpi/fortran/use-mpi-f08/base/bigcount.h" |
There was a problem hiding this comment.
good catch. patched that one too.
This PR refactors some of the f08 template files introduced in PR open-mpi#12621. Many of them had been using, incorrectly, macros from fint_2_int.h. The code in the use-mpi-f08 folder now makes use of generated code in the wrapper around the internal c code to avoid many of the problems that these older macros were trying to solve by providing 'c' interfaces directly to the fortran compiler. Also, generalized macros for handling translation of arrays of MPI_Fint's to c int's (and other types) are used in these templates. Related to open-mpi#13168 and associated issue raised by a user on the mail list. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
refactor_f08_templates
branch
from
a80f1a4 to
493a6f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors some of the f08 template files introduced in PR #12621. Many of them had been using, incorrectly, macros from fint_2_int.h. The code in the use-mpi-f08 folder now makes use of generated code in the wrapper around the internal c code to avoid many of the problems that these older macros were trying to solve by providing 'c' interfaces directly to the fortran compiler. Also, generalized macros for handling translation of arrays of MPI_Fint's to c int's (and other types) are used in these templates.
Related to #13168 and associated issue raised by a user on the mail list.