-
Notifications
You must be signed in to change notification settings - Fork 21
Simple addition to controll multi-axis odrives such as 3.6 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that ODrive v3.6 is a legacy product, which is why it's not actively supported in this library. Therefore I am also hesitant with a change like this. It needs to not affect maintainability / support load and not look like ODrive v3.6 is officially supported (because we don't have the resources for that). I need to think about those points. Meanwhile some comments.
Btw, if we would officially support a multi-axis ODrive with this library, it's likely that we'd want a slightly different usage approach: I'm thinking of one high-level device object that provides device-level functionality and one or more child "axis" objects that provide axis level functionality.
@@ -18,6 +18,9 @@ class ODriveUART { | |||
*/ | |||
ODriveUART(Stream& serial); | |||
|
|||
void selectAxis(int axis); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would have to be documented, especially that it can be ignored for all current-generation ODrives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above, could be mitigated with the overload
|
Hi, I am currently using the UART implementation of the library with an ODrive 3.6 and needed the possibility to change the controlled axis.
To change as little as possible I added a command to set and get the
kMotorNumber
variable.Set and Get state also now check this variable.
This can for sure be done in a more elegant way but I needed a quick solution.