Update with changes from upstream #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ertificate-handling fix: self signed certificate handling in v7.7.0
…y#2328) * Issue 2311: runtime error: index out of range [0] with length 0 while extracting state of of the csrf --------- Co-authored-by: tuunit <jan@larwig.com>
When listening to a unix socket there is no RemoteAddr for http.Request. Instead of setting nil, Go sets it to '@'. Marking the IP as trusted if RemoteAddr allows rest of the settings for parsing remote address in headers to be applied. Signed-off-by: Josef Johansson <josef@oderland.se>
When using sockets to pass data between e.g. nginx and oauth2-proxy it's
simpler to use sockets. Systemd can even facilitate this and pass the
actual socket directly.
This also means that only the socket runs with the same group as nginx
while the service runs with DynamicUser.
Does not support TLS yet.
nginx
```
server {
location /oauth2/ {
proxy_pass http://unix:/run/oauth2-proxy/oauth2.sock;
}
```
oauth2-proxy.socket
```
[Socket]
ListenStream=%t/oauth2.sock
SocketGroup=www-data
SocketMode=0660
```
Start oauth2-proxy with the parameter `--http-address=fd:3`.
Signed-off-by: Josef Johansson <josef@oderland.se>
* new readme structure * add adopters file * add microsoft sponsorship * add reference to adopter file * add gopher slack invite link * slightly rephrase nightly image section * add sponsor request for action * better formatting for contributor wall * add longer wait time for stale PRs and issues and allow for exemption through bug and high-priority labels * apply review suggestion Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk> --------- Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
Add support for systemd socket
The [RFC](https://datatracker.ietf.org/doc/html/rfc7636#section-4.1) says that a code verifier just uses unreserved characters, but the recommended method is that it is a base64-urlencoded 32-octet url. Some implementations of PKCE (most notably the one used by salesforce) require that this is a valid base64 encoded string[1], so this patch switches to using the recommended approach to make it more compatible. [1]: https://help.salesforce.com/s/articleView?id=sf.remoteaccess_pkce.htm&type=5
…g implicit setting of the groups scope when no scope was specified in the config Co-authored-by: Jan Larwig <jan@larwig.com>
…auth2-proxy#2888) --------- Co-authored-by: Jan Larwig <jan@larwig.com>
…during-docker-built fix: missing oauth2-proxy version for docker builds
…y#2934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chore(deps/build): bump golang to 1.23 and use go.mod as single point of truth for all build files
…issue-template doc: add entra id to issue templates
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Grant Linville <grant@acorn.io>
thedadams
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter failures in the CI are unconcerning. It also fails on the current
otto8branch.