fix: handle winborder in neovim-0.11 #649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the user may override the global window border for all windows for which the border wasn't explicitly set. For the scrollbar and the scrollbar thumb, we don't want any border. In the past we achieved that by now specifying a border, but with winborder, the user may set the border and then the scrollbar looks broken. So now we explicitly say that we want no border on these two windows, fixing the issue.
emmanueltouzery
changed the title
|
works for me |
|
works for me. |
|
works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neovim 0.11 introduced winborder: neovim/neovim#31074
This means that the user may override the global window border for all windows for which the border wasn't explicitly set.
In the past we achieved borderless windows by not specifying a border, but with winborder, the user may set the border and then the UI looks broken. So now we explicitly say that we want no border on the windows where we intended it so.
I tested this commit on neovim 0.10.2 as well, without issues.
To reproduce the issue on neovim 0.11, run:
and for instance open telescope, which is a plenary-using plugin showing the issue.
fixes nvim-telescope/telescope.nvim#3436
note that i do NOT have a clear vision of the whole plenary popups code, i just found the two windows that got a border with winborder that shouldn't, and enforced no border.