Add StyleCop.Analyzers #1663
Merged
Add StyleCop.Analyzers #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings are taken from nunit framework project. With the following exceptions: 1. Braces are optional. 2. The this. prefix is not defined
CharliePoole
approved these changes
Apr 13, 2025
| @@ -36,7 +37,8 @@ public static ProcessResult Run(ProcessStartInfo startInfo) | |||
| }; | |||
| process.ErrorDataReceived += (sender, e) => | |||
| { | |||
| if (e.Data == null) return; | |||
| if (e.Data == null) | |||
| return; | |||
There was a problem hiding this comment.
Another kind of thing where I find the rule overly pedantic, but at least it doesn't force adding parens.
There was a problem hiding this comment.
If it starts to annoy you we can disable rule SA1501, but until them leave it.
| public TestSelectionParserException(string message, Exception innerException) : base(message, innerException) { } | ||
| public TestSelectionParserException(string message, Exception innerException) : base(message, innerException) | ||
| { | ||
| } |
There was a problem hiding this comment.
I see a number of these. Depending on what happens when I try to put the empty braces on the same line, I may get annoyed at StyleCop for not being smart enough to see that there is nothing in the braces so don't worry. :-)
But let's give it a go anyway.
There was a problem hiding this comment.
If it starts to annoys you we can switch off rule SA1502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #1590
Settings are taken from nunit framework project.
With the following exceptions:
We can either leave it, or enforce the use of 'this.' or deny the the use of 'this.'.
The latter has my preference.