Skip to content

Wave functionality #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 13, 2025
Merged

Wave functionality #122

merged 14 commits into from
May 13, 2025

Conversation

MythicalFish
Copy link
Collaborator

@MythicalFish MythicalFish changed the base branch from main to test-generation May 3, 2025 11:51
@MythicalFish MythicalFish changed the title Wave utility Wave functionality May 5, 2025
Base automatically changed from test-generation to main May 6, 2025 00:23
@MythicalFish MythicalFish marked this pull request as ready for review May 6, 2025 11:03
@odagayev
Copy link
Collaborator

odagayev commented May 6, 2025

Hi Jake - good progress.

Some feedback;

  • CSS seems to breaking with the nf-test
    image

  • Can you please add a link to the build logs on the toast status that pops up? https://wave.seqera.io/view/builds/{build_id}

  • clicking generate container in a logged out state does not prompt the user the log in.

  • can you change the nf-test icon to use the a beaker (https://brand.seqera.net/icons). Empty for non-tested. Full beaker for tested.

@MythicalFish
Copy link
Collaborator Author

Hi @odagayev, I've implemented the feedback

I thought auth was working but turns out there was an edge case I wasn't seeing. Should be better now. :)
Regarding the icons, the ones on our brand page aren't suitable as very small icons, as they're very fine and too detailed. I've instead used the vscode/codicons beaker which looks nice

@odagayev
Copy link
Collaborator

odagayev commented May 7, 2025

Looking good. Some additional points:

  • we should just get rid of the text.
image
  • When I hit "Enter" after generating a container it puts "wave" to my clipboard.

Copy link
Member

@bentsherman bentsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it and works like a charm! Great work guys

@bentsherman bentsherman merged commit 821031a into main May 13, 2025
@bentsherman bentsherman deleted the wave branch May 13, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants