Nautobot 2.4.6 version compatibility #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ def is_truthy(arg): | |||
| { | |||
| "nautobot_docker_compose": { | |||
| "project_name": "nautobot_docker_compose", | |||
| "python_ver": "3.8", | |||
| "python_ver": "3.9", | |||
There was a problem hiding this comment.
Should we default to a newer version like 3.11?
There was a problem hiding this comment.
I just bumped to the minimum like it was, but I think we should set this to the preferred version by default, then users can select what they need if it differs.
pyproject.toml
Outdated
| @@ -5,8 +5,8 @@ description = "" | |||
| authors = ["John Doe <johndoe@mail.com>"] | |||
There was a problem hiding this comment.
Can/should we update any of the above while we're in here?
There was a problem hiding this comment.
Yes, and I touched it up a bit with a version bump. Do we need anything else here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Nautobot to 2.4.6 and fixed python dependencies.