Skip to content

Mention that Simple Vector Store data is accessible to all users #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025

Conversation

Cadiac
Copy link
Contributor

@Cadiac Cadiac commented May 22, 2025

Hey! We're changing Simple Vector Stores at PR n8n-io/n8n#15421, changing the Memory Key picker to a resource locator that lists all currently existing vector stores in memory. This is introduced on a new version of the In-Memory vector store node, version 1.2, to be shipped at next n8n beta version once that PR gets merged.

Another substantial change at that PR is that we're removing the workflow prefixing done by n8n at the backend from these nodes on version 1.2. This removes the workflow level isolation and enables the Simple Vector Stores to be used across workflows, but this also means that any instance users can now access data stored on the in memory vector stores regardless of their access to workflows. We've adjusted the warning on the UI to mention this, but docs should also change here.

This docs page also mentions the workflow isolation bunch of times. I didn't touch those, but that is changing with the new version of the node. Old nodes still respect the workflow level isolation, but the new version can also select stores created by the older versions of the node by picking the workflow prefixed items from the list. Some adjustments to the texts here should be made.

Copy link

netlify bot commented May 22, 2025

Deploy Preview for n8n-docs ready!

Name Link
🔨 Latest commit 6c04468
🔍 Latest deploy log https://app.netlify.com/projects/n8n-docs/deploys/6836d5da57fbe90008e81aae
😎 Deploy Preview https://deploy-preview-3181--n8n-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@imchairmanm
Copy link
Contributor

Hey @Cadiac thanks for the PR! So to summarize, the changes that the docs need to account for are:

  • The simple vector store has a new interface for setting the memory key by selecting it from a list populated by with the memory keys the instance currently has available (I assume with a "create" option as one of the choices).
  • Simple vector store data is now scoped to the instance instead of an idividual workflow. We don't have access controls in place, so users should be aware that the data inside will be accessible to any user of the instance.
  • Workflow isolation with this node is no longer much of a thing and we should remove references to that throughout the docs.

Does that sound about right to you or do I need some adjustments?

@Cadiac
Copy link
Contributor Author

Cadiac commented May 23, 2025

Hey @Cadiac thanks for the PR! So to summarize, the changes that the docs need to account for are:

  • The simple vector store has a new interface for setting the memory key by selecting it from a list populated by with the memory keys the instance currently has available (I assume with a "create" option as one of the choices).
  • Simple vector store data is now scoped to the instance instead of an idividual workflow. We don't have access controls in place, so users should be aware that the data inside will be accessible to any user of the instance.
  • Workflow isolation with this node is no longer much of a thing and we should remove references to that throughout the docs.

Does that sound about right to you or do I need some adjustments?

Exactly!

Old versions of SImple Vector Store will still behave as if they were workflow isolated, but other workflows using the newer version of the node can select vector stores created by these old nodes - they'll show up on the list with a workflow id prefix like workflowid__memory-key-name-here. I would remove the workflow isolation mentions, or mention that its only on n8n <1.95

@imchairmanm
Copy link
Contributor

@Cadiac I pushed some changes up to try to address some of the things we discussed earlier. Can you take a look when you have a moment to see if these make sense?

Copy link
Contributor Author

@Cadiac Cadiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems accurate, small typo to fix

@imchairmanm
Copy link
Contributor

Seems accurate, small typo to fix

Ah, thanks for the catch. Should I go ahead and merge once fixed or do we need to wait on anything?

@Cadiac
Copy link
Contributor Author

Cadiac commented May 28, 2025

I would say go ahead, this is already in beta and will be in stable next week

Copy link

Summary

Status Count
🔍 Total 12
✅ Successful 3
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 9
❓ Unknown 0
🚫 Errors 0
Full Github Actions output

@imchairmanm imchairmanm merged commit 7aeb91a into main May 28, 2025
7 checks passed
@imchairmanm imchairmanm deleted the ado-3518-memory-key-selector branch May 28, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants