-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Mention that Simple Vector Store data is accessible to all users #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for n8n-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hey @Cadiac thanks for the PR! So to summarize, the changes that the docs need to account for are:
Does that sound about right to you or do I need some adjustments? |
Exactly! Old versions of SImple Vector Store will still behave as if they were workflow isolated, but other workflows using the newer version of the node can select vector stores created by these old nodes - they'll show up on the list with a workflow id prefix like |
@Cadiac I pushed some changes up to try to address some of the things we discussed earlier. Can you take a look when you have a moment to see if these make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems accurate, small typo to fix
docs/integrations/builtin/cluster-nodes/root-nodes/n8n-nodes-langchain.vectorstoreinmemory.md
Outdated
Show resolved
Hide resolved
docs/integrations/builtin/cluster-nodes/root-nodes/n8n-nodes-langchain.vectorstoreinmemory.md
Show resolved
Hide resolved
Ah, thanks for the catch. Should I go ahead and merge once fixed or do we need to wait on anything? |
I would say go ahead, this is already in beta and will be in stable next week |
Summary
|
Hey! We're changing Simple Vector Stores at PR n8n-io/n8n#15421, changing the
Memory Key
picker to a resource locator that lists all currently existing vector stores in memory. This is introduced on a new version of the In-Memory vector store node, version 1.2, to be shipped at next n8n beta version once that PR gets merged.Another substantial change at that PR is that we're removing the workflow prefixing done by n8n at the backend from these nodes on version 1.2. This removes the workflow level isolation and enables the Simple Vector Stores to be used across workflows, but this also means that any instance users can now access data stored on the in memory vector stores regardless of their access to workflows. We've adjusted the warning on the UI to mention this, but docs should also change here.
This docs page also mentions the workflow isolation bunch of times. I didn't touch those, but that is changing with the new version of the node. Old nodes still respect the workflow level isolation, but the new version can also select stores created by the older versions of the node by picking the workflow prefixed items from the list. Some adjustments to the texts here should be made.