CSHARP-5592: Separate unit tests into dedicated variants #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2025 17:43
papafe
reviewed
May 20, 2025
| @@ -18,10 +18,12 @@ | |||
| using MongoDB.Bson; | |||
| using MongoDB.Driver.Linq.Linq3Implementation; | |||
| using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToExecutableQueryTranslators; | |||
| using MongoDB.TestHelpers.XunitExtensions; | |||
There was a problem hiding this comment.
Same also in some other files
There was a problem hiding this comment.
Let me check. There were several iteration of switching in between TraitAttribute and custom attribute. It might be a leftovers.
papafe
reviewed
May 20, 2025
| using MongoDB.Driver.Linq.Linq3Implementation; | ||
| using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToExecutableQueryTranslators; | ||
| using Xunit; | ||
|
|
||
| using MongoDB.TestHelpers.XunitExtensions;using Xunit; |
There was a problem hiding this comment.
They should not be on the same line. (And maybe the first using is not necessary?)
papafe
reviewed
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've marked all tests that require MongoDB connection with Category=Integration. Then I've adjusted cake to run ONLY Integration tests and created a new variants to run unit tests (tests that do not belong to Integration category).