Skip to content

chore(NODE-6938): update typescript to 5.8.3 #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

chore(NODE-6938): update typescript to 5.8.3 #793

merged 2 commits into from
May 5, 2025

Conversation

durran
Copy link
Member

@durran durran commented Apr 30, 2025 •
edited
Loading

Description

Updates typescript to 5.8.3

What is changing?

  • Update typescript.
  • Updates dependencies that were out of date with the TS update.
  • Enable erasableSyntaxOnly option.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6938

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review April 30, 2025 11:49
@durran durran requested a review from a team as a code owner April 30, 2025 11:49
@nbbeeken nbbeeken mentioned this pull request Apr 30, 2025
Closed
5 tasks
nbbeeken
nbbeeken previously requested changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts?

@nbbeeken nbbeeken self-assigned this Apr 30, 2025
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 30, 2025
@nbbeeken
Copy link
Contributor

https://spruce.mongodb.com/version/681245af608cfa0007dcd01b

Let's run some driver patches to confirm this doesn't have an impact on perf, or let's skip setting this flag for now and just update TS.

@durran
Copy link
Member Author

durran commented May 5, 2025

Driver perf tasks: https://spruce.mongodb.com/version/6818be796062e80007577e00/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

@baileympearson baileympearson self-assigned this May 5, 2025
@durran
Copy link
Member Author

durran commented May 5, 2025

Looks like no perf hit from the patch.

@baileympearson baileympearson dismissed nbbeeken’s stale review May 5, 2025 16:48

No longer reviewing.

@baileympearson baileympearson merged commit 86f9dc4 into main May 5, 2025
8 checks passed
@baileympearson baileympearson deleted the NODE-6938 branch May 5, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@nbbeeken nbbeeken nbbeeken left review comments

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @nbbeeken @baileympearson