Rename ReScript Schema to Sury #1831
Conversation
| @@ -87,7 +87,7 @@ export const packages = [ | |||
| packageName: 'r-assign', | |||
| }, | |||
| { | |||
| name: 'rescript-schema', | |||
| name: 'sury', | |||
| packageName: 'rescript-schema', | |||
There was a problem hiding this comment.
Kept it as rescript-schema for now. I'll update it later when users migrate to sury
There was a problem hiding this comment.
mhh okay.
From my POV it maybe would have been cleaner then to just add sury as a new library to the benchmark and remove rescript-schema once the migration is done.
Could you maybe please add a comment though in case someone wonders about the naming mismatch 😁 ? thx!
|
@moltar Yes, it's just a rename. What do you mean by keeping historical data? |
|
I think having it stay as a rescript schema is fine. |
Historical benchmark values |
| @@ -87,7 +87,7 @@ export const packages = [ | |||
| packageName: 'r-assign', | |||
| }, | |||
| { | |||
| name: 'rescript-schema', | |||
| name: 'sury', | |||
| packageName: 'rescript-schema', | |||
There was a problem hiding this comment.
mhh okay.
From my POV it maybe would have been cleaner then to just add sury as a new library to the benchmark and remove rescript-schema once the migration is done.
Could you maybe please add a comment though in case someone wonders about the naming mismatch 😁 ? thx!
The data already exists in the commits and commit messages. To make sense out of it I would add a separate history_changes.json or so that tracks metadata events like project-renames, changes to the benchmarks and changes to the projects structure. That way a future historical data viewer would be able to interpret and assemble the benchmark history. As that history-viewer doesn't exist yet, I don't think we need to do anything now. |
|
Hm, keeping both actually makes sense, since rescript-schema is still a valid name in ReScript community |
I mean, feel free to change the PR as it is not merged yet 😁 |
This is a rebranding from my side.
https://github.com/DZakh/sury