Skip to content

Add fix for hyphens in enum values #4202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

Add fix for hyphens in enum values #4202

merged 2 commits into from
May 8, 2025

Conversation

johnoliver
Copy link
Member

Fix # .

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated

@harsimar harsimar mentioned this pull request May 6, 2025
Open
harsimar
harsimar approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@harsimar harsimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good, just a minor nit about the assertion in the test.

@harsimar harsimar merged commit 7c234b7 into microsoft:main May 8, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsimar harsimar harsimar approved these changes

@TimothyMothra TimothyMothra TimothyMothra approved these changes

@jeanbisutti jeanbisutti Awaiting requested review from jeanbisutti jeanbisutti is a code owner

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@trask trask Awaiting requested review from trask trask is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnoliver @harsimar @TimothyMothra