-
Notifications
You must be signed in to change notification settings - Fork 3.3k
+MongoDB Vector Support #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
+MongoDB Vector Support #2367
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Dev-Khant could you please take a look at this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the relevant docs and tests for it. Thanks.
@Dev-Khant will add this soon! Sorry for delay |
Adding initial tests, updating use of get_embeddings Remove accidental formatting to unrelated files Fixing tests Fixing docs, adding comment Remove get_embeddings
Hi @Dev-Khant , this PR is ready for re-review when you get a second! |
When would this be closed? |
Hey @ranfysvalle02 Can you please resolve the merge conflicts so we can run the CI tests. |
@Dev-Khant -- merge conflicts resolved!!! |
@Dev-Khant - Just following up here, let me know if any issues |
@Dev-Khant --- We are about to have more merge conflicts -- Can you please advise if there is anything wrong with the MongoDB aspect of it or help get this merged please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry the delay here. Left few comments once it's resolved we can merge this.
"""Configuration for MongoDB vector database.""" | ||
|
||
db_name: str = Field("mem0_db", description="Name of the MongoDB database") | ||
collection_name: str = Field("mem0_collection", description="Name of the MongoDB collection") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep collection name as mem0
pyproject.toml
Outdated
@@ -31,6 +31,7 @@ langchain-neo4j = "^0.4.0" | |||
neo4j = "^5.23.1" | |||
rank-bm25 = "^0.2.2" | |||
psycopg2-binary = "^2.9.10" | |||
pymongo = "^4.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove pymongo
from the default dependencies. User can install this separately when they want to use mongodb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add the reset
method as well?
poetry.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will no poetry changes once you remove the pymonogo
from default dependencies
Also @ranfysvalle02 Can you please why the monogodb tests are failing? |
@Dev-Khant give me a bit to tackle all this -- will report back soon! |
Description
Add MongoDB as a VectorDB.
Fixes # (issue)
#1166
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
There is working code that highlights how to use, and the output.
Please delete options that are not relevant.
Checklist:
Maintainer Checklist