Skip to content

Alterations #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

danheberden
Copy link

Adjusted the markup to use a div with ui's css frame work instead of h4/p tags that might get some crazy styling from the page.

@mekwall
Copy link
Owner

mekwall commented Feb 14, 2011

Good idea, badly executed! ;)

The point behind using h4 and p elements is because they are supposed to inherit styles from the rest of your page. If it looks like crap you can easily change the css or just change the template. So I'm not convinced that this change is necessary at all, but would be interesting to hear your case.

@danheberden
Copy link
Author

sry for the poor execution. perhaps I was mistaken that this was designed as a jquery-ui type plugin and not just jquery ui as in a vanilla UI term.

My case, assuming the former, would be that dialog doesn't use h4 and p tags. Of course you could style any element however you want to, I was just pointing out the jquery ui css framework as an option. But I think I mis-understood the title of the repo and blog post, so my apologies :) It works great, btw - fantastic work!

@mekwall
Copy link
Owner

mekwall commented Feb 14, 2011

Dan, your point is valid and I'm going to take it into consideration when overhauling the templating part of the plugin (add support for $.tmpl). We also need to find a solution to the nesting widget styles pointed out by ajpiano. Overhauling the widget layout might be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants