Fix order of parameters in call to _addTimeDistance when using a RTL waypoint #12729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix order of parameters in call to _addTimeDistance when using a RTH waypoint
Description
This corrects the order of parameters when calling MissionController::_addTimeDistance
Note that the last 3 parameters are
time
,distance
andsequenceNumber
(in that order), and they are used correctly everywhere except where corrected by this PR, where previously they had been ordereddistance
,time
andsequenceNumber
(notetime
anddistance
were swapped).This escaped the compiler because both parameters are
double
.As a result:
-.-
.Test Steps
Create a new Plan from scratch in the Plan View:
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.