[WIP] feat(freight): (Logistics) use CarrierShipments for Delivery #3871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the failing tests from commit e18f641
…livery # Conflicts: # contribs/freight/src/main/java/org/matsim/freight/carriers/jsprit/MatsimJspritFactory.java # contribs/freight/src/main/java/org/matsim/freight/carriers/usecases/chessboard/FreightScenarioCreator.java # contribs/freight/src/main/java/org/matsim/freight/logistics/examples/initialPlans/ExampleTwoEchelonGrid.java # contribs/freight/src/main/java/org/matsim/freight/logistics/examples/initialPlans/ExampleTwoEchelonGrid_NR.java # contribs/freight/src/main/java/org/matsim/freight/logistics/resourceImplementations/CarrierSchedulerUtils.java # contribs/freight/src/main/java/org/matsim/freight/logistics/resourceImplementations/CollectionCarrierScheduler.java # contribs/freight/src/main/java/org/matsim/freight/logistics/resourceImplementations/DistributionCarrierScheduler.java # contribs/freight/src/main/java/org/matsim/freight/logistics/resourceImplementations/LSPTourStartEventHandler.java # contribs/freight/src/main/java/org/matsim/freight/logistics/resourceImplementations/MainRunCarrierScheduler.java # contribs/freight/src/test/java/org/matsim/freight/logistics/resourceImplementations/MultipleShipmentsSecondReloadLSPSchedulingTest.java # contribs/freight/src/test/java/org/matsim/freight/logistics/resourceImplementations/SecondReloadLSPSchedulingTest.java
Note: Nothing changed to set this in the builder, so they may be null...
kt86
changed the title
|
Please use |
@sebhoerl : I can change it. The reason: Carriers is the old freight contrib, used from some groups independently, while logistics is a new package. |
kt86
changed the title
|
ah ok, if there is a good reason, fine for me ;) |
Run settings for ban large vehicle Todos and comments
…d daher es dann knallt, weil shipment keinen Plan hat.... args.
…very # Conflicts: # contribs/freight/src/main/java/org/matsim/freight/logistics/examples/multipleChains/ExampleTwoLspsGroceryDeliveryMultipleChainsWithToll.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, the delivery is planned based on
CarrierServices.VRPs with Services cannot use a vehicle for more than one subtour, so it runs only once. As a consequence there are - for the last mile - too many vehicles on the road, leading to too much fixed costs.
Solution:
With this PR, it is now possible to plan the delivery based on
CarrierShipments, allowing the Vehicle to return to the depot/hub and reload goods for the next (sub-)tour.Other changes:
isWithinBound(...)method for the tests to reduce code-duplication in various tests.