Helm version check fails with Fedora packaged Helm #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
mayooot
force-pushed
the
fix/checkhelmverison
branch
from
7688dc9 to
58a4ce6
Compare
cbron
reviewed
Apr 11, 2025
| if !strings.HasPrefix(output, "v") { | ||
| output = "v" + output | ||
| } | ||
|
|
||
| if semver.Compare(output, MinHelmVersion) == -1 { |
There was a problem hiding this comment.
Hello, thanks for sending a PR. Could you add some unit tests for this ? Would like to track the types of version that we are supporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2545
Please provide a short message that should be published in the vcluster release notes
CheckHelmVersion function adapts version that do not begin with 'v'
What else do we need to know?
nothing