Skip to content

[v0.24] fix: update wording in ESO schema #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

[v0.24] fix: update wording in ESO schema #2645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions chart/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1848,15 +1848,15 @@
"properties": {
"externalSecrets": {
"$ref": "#/$defs/EnableSwitch",
"description": "ExternalSecrets defines whether to sync external secrets or not"
"description": "ExternalSecrets defines if external secrets should get synced from the virtual cluster to the host cluster."
},
"stores": {
"$ref": "#/$defs/EnableSwitch",
"description": "Stores defines whether to sync stores or not"
"description": "Stores defines if secret stores should get synced from the virtual cluster to the host cluster."
},
"clusterStores": {
"$ref": "#/$defs/ClusterStoresSyncConfig",
"description": "ClusterStores defines whether to sync cluster stores or not"
"description": "ClusterStores defines if cluster secrets stores should get synced from the host cluster to the virtual cluster."
}
},
"additionalProperties": false,
Expand Down Expand Up @@ -2029,7 +2029,7 @@
},
"externalSecrets": {
"$ref": "#/$defs/ExternalSecrets",
"description": "ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster"
"description": "ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.\n- ExternalSecrets will be synced from the virtual cluster to the host cluster.\n- SecretStores will be synced bi-directionally.\n- ClusterSecretStores will be synced from the host cluster to the virtual cluster."
},
"certManager": {
"$ref": "#/$defs/CertManager",
Expand Down
11 changes: 7 additions & 4 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,10 @@ integrations:
# Pods defines if metrics-server pods api should get proxied from host to virtual cluster.
pods: true

# ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster
# ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.
# - ExternalSecrets will be synced from the virtual cluster to the host cluster.
# - SecretStores will be synced bi-directionally.
# - ClusterSecretStores will be synced from the host cluster to the virtual cluster.
externalSecrets:
# Enabled defines whether the external secret integration is enabled or not
enabled: false
Expand All @@ -742,13 +745,13 @@ integrations:
enabled: false
# Sync defines the syncing behavior for the integration
sync:
# ExternalSecrets defines whether to sync external secrets or not
# ExternalSecrets defines if external secrets should get synced from the virtual cluster to the host cluster.
externalSecrets:
enabled: true
# Stores defines whether to sync stores or not
# Stores defines if secret stores should get synced from the virtual cluster to the host cluster.
stores:
enabled: false
# ClusterStores defines whether to sync cluster stores or not
# ClusterStores defines if cluster secrets stores should get synced from the host cluster to the virtual cluster.
clusterStores:
# Enabled defines if this option should be enabled.
enabled: false
Expand Down
11 changes: 7 additions & 4 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ type Integrations struct {
// KubeVirt reuses a host kubevirt and makes certain CRDs from it available inside the vCluster
KubeVirt KubeVirt `json:"kubeVirt,omitempty"`

// ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster
// ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.
// - ExternalSecrets will be synced from the virtual cluster to the host cluster.
// - SecretStores will be synced bi-directionally.
// - ClusterSecretStores will be synced from the host cluster to the virtual cluster.
ExternalSecrets ExternalSecrets `json:"externalSecrets,omitempty"`

// CertManager reuses a host cert-manager and makes its CRDs from it available inside the vCluster.
Expand Down Expand Up @@ -142,11 +145,11 @@ type ExternalSecrets struct {
}

type ExternalSecretsSync struct {
// ExternalSecrets defines whether to sync external secrets or not
// ExternalSecrets defines if external secrets should get synced from the virtual cluster to the host cluster.
ExternalSecrets EnableSwitch `json:"externalSecrets,omitempty"`
// Stores defines whether to sync stores or not
// Stores defines if secret stores should get synced from the virtual cluster to the host cluster.
Stores EnableSwitch `json:"stores,omitempty"`
// ClusterStores defines whether to sync cluster stores or not
// ClusterStores defines if cluster secrets stores should get synced from the host cluster to the virtual cluster.
ClusterStores ClusterStoresSyncConfig `json:"clusterStores,omitempty"`
}

Expand Down
Loading