Option to disable cookie store (2)

[novitae]

A clean solution for #477. This is a duplicate of #488 (it was on my main branch and I wanted to make another PR).

[dolfies]

Same comment as the dupe: I would argue that this should just be done by the user

[lexiforest]

Let me tinker on this idea while fixing other urgent issues.

[lexiforest]

I think this is actually a good idea, I know the users can use the dummy cookiejar to disable cookies in a session, but the elegancy of requests API is that you only need to import requests and that's it. The arguments are rich, but you don't have to import or know them if you don't need them. And with typehints, it's actually easier to discovery and safeguard the arguments.

My only question is: do you think discard_cookies is a better name?

[novitae]

My only question is: do you think discard_cookies is a better name?

Yes it is. I updated the for it.

[dolfies]

I think this is actually a good idea, I know the users can use the dummy cookiejar to disable cookies in a session, but the elegancy of requests API is that you only need to import requests and that's it. The arguments are rich, but you don't have to import or know them if you don't need them. And with typehints, it's actually easier to discovery and safeguard the arguments.

My only question is: do you think discard_cookies is a better name?

It's up to you but I was just thinking we don't want scope creep on an already quite "batteries-included" library, especially when there's already a more powerful solution for this (a custom cookie jar)