sqlx-core: impl IntoArguments for Arguments #3833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxzhao527
changed the title
hxzhao527
changed the title
hxzhao527
changed the title
hxzhao527
changed the title
abonander
requested changes
May 5, 2025
Comment on lines
+40
to
+49
| // impl<'q> | ||
| // $crate::arguments::IntoArguments< | ||
| // 'q, | ||
| // <$Arguments as $crate::arguments::Arguments<'q>>::Database, | ||
| // > for $Arguments | ||
| // { | ||
| // fn into_arguments(self) -> $Arguments { | ||
| // self | ||
| // } | ||
| // } |
There was a problem hiding this comment.
If this macro is obsoleted by this PR then it should just be deleted.
| [[test]] | ||
| name = "generic-postgres" | ||
| path = "tests/generic/postgres.rs" | ||
| required-features = ["postgres", "macros"] |
There was a problem hiding this comment.
Missing newline at the end of this file.
| .try_map(|row: <E::Database as Database>::Row| row.try_get::<i32, _>(0)) | ||
| .fetch_one(e) | ||
| .await | ||
| } |
There was a problem hiding this comment.
It's not immediately obvious how this test relates to the purpose of this PR. Can you add a comment explaining that?
|
@abonander thanks for your review. I have re-checked the issues I encountered and finally understood the concept of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
fixes #3834
Is this a breaking change?
struct which impl both
ArgumentsandIntoArgumentswill conflict now.