feat: add more support for different workload types #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepyfoodie
changed the title
skl
reviewed
Apr 24, 2025
skl
reviewed
Apr 25, 2025
skl
reviewed
Apr 30, 2025
There was a problem hiding this comment.
There is another non-standard workload rule missing for workloads you would see from the following query:
group by (owner_kind) (kube_pod_owner{owner_kind!="ReplicaSet", owner_kind!="DaemonSet", owner_kind!="StatefulSet", owner_kind!="Job", owner_kind!="Node", owner_kind!=""})
That should capture workload types that are directly controlled via CRDs like StrimziPodSet for example.
No join is required for this additional rule as the pods are created directly rather than via ReplicaSets.
Co-authored-by: Stephen Lang <skl@users.noreply.github.com>
Co-authored-by: Stephen Lang <skl@users.noreply.github.com>
Co-authored-by: Stephen Lang <skl@users.noreply.github.com>
skl
reviewed
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update workload recording rules to support more workload type
New recording rules tested have good health status:
