-
Notifications
You must be signed in to change notification settings - Fork 610
fix a typo in broker readme: kantive #8573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @pacoxu! It looks like this is your first PR to knative/eventing 🎉 |
Hi @pacoxu. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
Thanks for the fix!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8573 +/- ##
=======================================
Coverage 52.31% 52.31%
=======================================
Files 397 397
Lines 24925 24925
=======================================
Hits 13039 13039
Misses 11099 11099
Partials 787 787 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A typo.