Skip to content

fix(dashboards): check access only for non-empty namespace (#141) #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

fix(dashboards): check access only for non-empty namespace (#141) #144

merged 1 commit into from
May 15, 2025

Conversation

fhussonnois
Copy link
Member

Fix: #141

@github-project-automation github-project-automation bot moved this to To review in Pull Requests May 14, 2025
brian-mulier-p
brian-mulier-p approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhussonnois fhussonnois merged commit 9b8dcf7 into master May 15, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mulier-p brian-mulier-p brian-mulier-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pull Requests
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git.PushDashboards isn't working and lack required properties
2 participants
@fhussonnois @brian-mulier-p