Skip to content

🌱 test: add unit tests for related resources #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

🌱 test: add unit tests for related resources #43

wants to merge 7 commits into from

Conversation

cnvergence
Copy link
Member

@cnvergence cnvergence commented Mar 19, 2025 •
edited
Loading

Summary

This PR adds the basic unit tests for the related resources.

Related issue(s)

Fixes #33
As discussed, we have concluded that adding the optional field won't be necessary, PR was opened to add the missing unit tests for the related resources. #43

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Mar 19, 2025
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign embik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 19, 2025
@cnvergence cnvergence force-pushed the optional-published-resources branch from 50c52f3 to 6a7c0d6 Compare March 19, 2025 10:59
@cnvergence cnvergence changed the title feat: add optional related resources ✨ feat: add optional related resources Mar 19, 2025
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 19, 2025
@cnvergence cnvergence marked this pull request as ready for review March 19, 2025 12:34
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025
@cnvergence cnvergence force-pushed the optional-published-resources branch 4 times, most recently from 5cbec0b to 2f5479b Compare March 20, 2025 12:51
@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2025
@cnvergence cnvergence force-pushed the optional-published-resources branch 3 times, most recently from cb53388 to 97efc4c Compare March 21, 2025 11:41
@cnvergence cnvergence force-pushed the optional-published-resources branch from cf8d14a to 05c1537 Compare March 26, 2025 12:28
@cnvergence cnvergence requested a review from xrstf March 26, 2025 12:29
@cnvergence cnvergence changed the title ✨ feat: add optional related resources ✨ feat: add unit tests for related resources Mar 26, 2025
@cnvergence cnvergence mentioned this pull request Mar 26, 2025
Closed
1 task
@xrstf
Copy link
Contributor

xrstf commented Mar 26, 2025

For reference, this PR will be kind of obsolete once #44 merges, since that PR is already loosening the rules a bit and making everything optional already.

@cnvergence
Copy link
Member Author

I have added only unit tests for related resources, PTAL @xrstf

@cnvergence cnvergence marked this pull request as draft March 28, 2025 15:24
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2025
@cnvergence cnvergence force-pushed the optional-published-resources branch 2 times, most recently from a4ccd6a to b3da9e8 Compare April 11, 2025 14:58
@cnvergence cnvergence marked this pull request as ready for review April 11, 2025 14:58
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 11, 2025
@cnvergence cnvergence changed the title ✨ feat: add unit tests for related resources 🌱 test: add unit tests for related resources Apr 11, 2025
@cnvergence
feat: add optional published resources
6eda5cc 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
@cnvergence
update codegen
a47eef5 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
@cnvergence
add related resources tests
05e013c 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
@cnvergence
move the tests to seperate file
779d9ff 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
@cnvergence
add the unit tests for related resources
f68f776 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
@cnvergence
update tests
4b21f35 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
@cnvergence cnvergence force-pushed the optional-published-resources branch from b3da9e8 to a275995 Compare April 11, 2025 15:38
@cnvergence
update crds
39d2db1 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence force-pushed the optional-published-resources branch from a275995 to 39d2db1 Compare April 11, 2025 15:42
@xrstf
Copy link
Contributor

xrstf commented Apr 22, 2025

/retest

@kcp-ci-bot
Copy link
Contributor

@cnvergence: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-api-syncagent-test 39d2db1 link true /test pull-api-syncagent-test
pull-api-syncagent-lint 39d2db1 link true /test pull-api-syncagent-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xrstf
Copy link
Contributor

xrstf commented Apr 22, 2025

@cnvergence Looks like this is not finished?

@cnvergence
Copy link
Member Author

@xrstf yes, after pulling recent changes to the related resources, tests are failing once again
There are problems with not getting the relatedResource namespace in the unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: optional related resources
3 participants
@cnvergence @kcp-ci-bot @xrstf