Skip to content
This repository was archived by the owner on Jan 24, 2020. It is now read-only.

Validate cookie properties in the set method, with more meaningful error messages #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validate cookie properties in the set method, with more meaningful error messages #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 81 additions & 44 deletions ios/RNCookieManagerIOS/RNCookieManagerIOS.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,67 +10,103 @@ @implementation RNCookieManagerIOS
RCT_EXPORT_MODULE()

RCT_EXPORT_METHOD(set:(NSDictionary *)props
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {

// Check if mandatory properties are provided

NSArray* mandatoryProps = @[@"path", @"name", @"value"];

for(NSString* propName in mandatoryProps) {
if (props[propName] == [NSNull null] || props[propName] == nil) {
NSString* errorMsg = [NSString stringWithFormat:@"Cookie property '%@' must be provided", propName];
reject(@"missing_required_prop", errorMsg, [NSError errorWithDomain:@"com.react.native.cookies" code:0 userInfo:@{NSLocalizedDescriptionKey:errorMsg}]);
return;
}
}

// Domain OR origin must be provided

if ((props[@"domain"] == [NSNull null] || props[@"domain"] == nil) &&
(props[@"origin"] == [NSNull null] || props[@"origin"] == nil)) {
NSString* errorMsg = @"At least one of 'domain' or 'origin' cookie properties must be provided";
reject(@"missing_required_prop", errorMsg, [NSError errorWithDomain:@"com.react.native.cookies" code:0 userInfo:@{NSLocalizedDescriptionKey:errorMsg}]);
return;
}

// Cookie is valid

NSString *path = [RCTConvert NSString:props[@"path"]];
NSString *name = [RCTConvert NSString:props[@"name"]];
NSString *value = [RCTConvert NSString:props[@"value"]];
NSString *domain = [RCTConvert NSString:props[@"domain"]];
NSString *origin = [RCTConvert NSString:props[@"origin"]];
NSString *path = [RCTConvert NSString:props[@"path"]];
NSString *version = [RCTConvert NSString:props[@"version"]];
NSDate *expiration = [RCTConvert NSDate:props[@"expiration"]];


NSMutableDictionary *cookieProperties = [NSMutableDictionary dictionary];
[cookieProperties setObject:path forKey:NSHTTPCookiePath];
[cookieProperties setObject:name forKey:NSHTTPCookieName];
[cookieProperties setObject:value forKey:NSHTTPCookieValue];
[cookieProperties setObject:domain forKey:NSHTTPCookieDomain];
[cookieProperties setObject:origin forKey:NSHTTPCookieOriginURL];
[cookieProperties setObject:path forKey:NSHTTPCookiePath];
[cookieProperties setObject:version forKey:NSHTTPCookieVersion];
[cookieProperties setObject:expiration forKey:NSHTTPCookieExpires];


if(props[@"domain"] != [NSNull null] && props[@"domain"] != nil) {
[cookieProperties setObject:[RCTConvert NSString:props[@"domain"]] forKey:NSHTTPCookieDomain];
}
if(props[@"origin"] != [NSNull null] && props[@"origin"] != nil) {
[cookieProperties setObject:[RCTConvert NSString:props[@"origin"]] forKey:NSHTTPCookieOriginURL];
}
if(props[@"version"] != [NSNull null] && props[@"version"] != nil) {
[cookieProperties setObject:[RCTConvert NSString:props[@"version"]] forKey:NSHTTPCookieVersion];
}
if(props[@"expiration"] != [NSNull null] && props[@"expiration"] != nil) {
[cookieProperties setObject:[RCTConvert NSDate:props[@"expiration"]] forKey:NSHTTPCookieExpires];
}

NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:cookieProperties];

NSLog(@"SETTING COOKIE");
NSLog(@"%@", cookieProperties);

NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:cookieProperties];

if (cookie == nil) {
NSString* errorMsg = @"Cookie creation failed, check the properties";
reject(@"cookie_creation_failed", errorMsg, [NSError errorWithDomain:@"com.react.native.cookies" code:0 userInfo:@{NSLocalizedDescriptionKey:errorMsg}]);
return;
}

[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];

resolve(nil);
}

RCT_EXPORT_METHOD(setFromResponse:(NSURL *)url
value:(NSDictionary *)value
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
value:(NSDictionary *)value
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:value forURL:url];
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookies:cookies forURL:url mainDocumentURL:NULL];
resolve(nil);
}

RCT_EXPORT_METHOD(getFromResponse:(NSURL *)url
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
NSURLRequest *request = [NSURLRequest requestWithURL:url];
[NSURLConnection sendAsynchronousRequest:request queue:[[NSOperationQueue alloc] init]
completionHandler:^(NSURLResponse *response, NSData *data, NSError *error) {

NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)response;
NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:httpResponse.allHeaderFields forURL:response.URL];
NSMutableDictionary *dics = [NSMutableDictionary dictionary];

for (int i = 0; i < cookies.count; i++) {
NSHTTPCookie *cookie = [cookies objectAtIndex:i];
[dics setObject:cookie.value forKey:cookie.name];
NSLog(@"cookie: name=%@, value=%@", cookie.name, cookie.value);
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];
}
resolve(dics);
}];
NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)response;
NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:httpResponse.allHeaderFields forURL:response.URL];
NSMutableDictionary *dics = [NSMutableDictionary dictionary];
for (int i = 0; i < cookies.count; i++) {
NSHTTPCookie *cookie = [cookies objectAtIndex:i];
[dics setObject:cookie.value forKey:cookie.name];
NSLog(@"cookie: name=%@, value=%@", cookie.name, cookie.value);
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];
}
resolve(dics);
}];
}

RCT_EXPORT_METHOD(get:(NSURL *) url
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
NSMutableDictionary *cookies = [NSMutableDictionary dictionary];
for (NSHTTPCookie *c in [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:url]) {
[cookies setObject:c.value forKey:c.name];
Expand All @@ -79,7 +115,7 @@ @implementation RNCookieManagerIOS
}

RCT_EXPORT_METHOD(clearAll:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
rejecter:(RCTPromiseRejectBlock)reject) {
NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
for (NSHTTPCookie *c in cookieStorage.cookies) {
[cookieStorage deleteCookie:c];
Expand All @@ -88,20 +124,20 @@ @implementation RNCookieManagerIOS
}

RCT_EXPORT_METHOD(clearByName:(NSString *) name
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
for (NSHTTPCookie *c in cookieStorage.cookies) {
if ([[c name] isEqualToString:name]) {
[cookieStorage deleteCookie:c];
}
if ([[c name] isEqualToString:name]) {
[cookieStorage deleteCookie:c];
}
}
resolve(nil);
}

// TODO: return a better formatted list of cookies per domain
RCT_EXPORT_METHOD(getAll:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
rejecter:(RCTPromiseRejectBlock)reject) {
NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
NSMutableDictionary *cookies = [NSMutableDictionary dictionary];
for (NSHTTPCookie *c in cookieStorage.cookies) {
Expand All @@ -116,3 +152,4 @@ @implementation RNCookieManagerIOS
}

@end