Skip to content

Include optional parentId when creating issues #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

larryhudson
Copy link

@larryhudson larryhudson commented Feb 16, 2025

Hi there, thanks for creating this MCP server! I'm trying it out using Cline in VS Code. I thought it would be useful to be able to specify a parent ID when creating a new issue, so that an existing issue can be broken up into smaller parts.

This PR adds the 'parentId' parameter to the 'create issue' tool and API calls. However, currently the 'parentId' needs to be a UUID, and I'm finding it a little difficult to use the 'search issues' tool - it's timing out for me. I'll try this out more later.

I tested this out by finding the UUID of an existing issue in the browser dev tools (looking at a GraphQL request) so at least including the 'parent ID' in the 'create issues' call is working.

Important

Add optional parentId to CreateIssueArgs and update createIssue method to support sub-issues in Linear.

  • Behavior:
    • Add optional parentId to CreateIssueArgs in index.ts for creating sub-issues.
    • Update createIssue method in LinearMCPClient to include parentId when creating issues.
  • Tools:
    • Update createIssueTool description and input schema to include parentId as an optional field for sub-issues.

This description was created by Ellipsis for 88f64c1. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 88f64c1 in 46 seconds

More details
  • Looked at 92 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 9 drafted comments based on config settings.
1. index.ts:24
  • Draft comment:
    Good addition of optional 'parentId' to CreateIssueArgs. Ensure this matches the API's expected type.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. index.ts:282
  • Draft comment:
    The createIssue method passes parentId correctly. Consider verifying that the API accepts an undefined parentId without issues.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. index.ts:529
  • Draft comment:
    The tool schema for 'linear_create_issue' now includes 'parentId' with a clear description. Nice work.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. index.ts:920
  • Draft comment:
    Minor formatting changes in template literals for listing issues. These changes improve consistency.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
5. index.ts:27
  • Draft comment:
    Added optional 'parentId' in CreateIssueArgs. Looks correct.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
6. index.ts:287
  • Draft comment:
    Pass 'parentId' in createIssue payload. Ensure API handles undefined gracefully.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
7. index.ts:522
  • Draft comment:
    Tool description and schema updated to include 'parentId' for sub-issues. Clear and consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
8. index.ts:926
  • Draft comment:
    Input handler now converts 'parentId' to string if provided. Consistent with other fields.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
9. index.ts:973
  • Draft comment:
    Formatting cleanup in the issues mapping output; purely cosmetic with no functional impact.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_PNckGALwwQrN7VVA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@jerhadf
Copy link
Owner

jerhadf commented Feb 17, 2025

@larryhudson nice! I think this addition makes sense. could you resolve the conflicts and then I'll approve and merge?

@larryhudson
Copy link
Author

Hey Jeremy, sorry for the delay. I've just resolved the conflicts, this should be good to go now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants