ALAudioRenderer: code improvements #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove recursive calls to updateSourceParam() method - more checkAlError - added helper methods - added comments - javadoc - fix Destroys the OpenAL context, deleting sources, buffers, filters, and effects.
|
Hi guys, |
You should consider using ArrayDeque when: You need a collection that efficiently supports adding and removing elements from both ends. This makes it ideal for implementing data structures like queues and stacks. You frequently perform removals from the beginning of the collection. see ALAudioRenderer.newChannel() and ALAudioRenderer.freeChannel()
removes the repeated call to the `checkAlError` method. The repeated string creation and the associated overhead of the error checking can negatively impact performance, especially in a frequently executed game loop. By removing this redundant check, we aim to improve overall performance and reduce garbage collection pressure.
|
I'll merge this in ~24 hours |
yaRnMcDonuts
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Not ready for review.
After studying the OpenAL API, this PR introduces small tweaks to make the code clearer and easier to understand.
Changes:
checkAlErrorcalls after relevant OpenAL operations.initOpenAL,initEfx, anddestroyOpenAL.restartAudioRendereris currently missingEnvironmentandListenersettings handling).