fix(labels): prevent clicking a label from triggering onClick twice on several components #30384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extarea, toggle, input) where clicking on a label would trigger onclick twice
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShaneK
changed the title
…igger onclick twice
ShaneK
changed the title
thetaPC
requested changes
May 1, 2025
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
thetaPC
approved these changes
May 2, 2025
brandyscarney
approved these changes
May 2, 2025
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30165
What is the current behavior?
Currently, several components will trigger their
onClicktwice if you click on their labels.What is the new behavior?
After this fix, the affected components will only trigger
onClickonce per click of their labels or click directly on the element.Does this introduce a breaking change?
Other information
The affected components are:
I also tested radio and range but could not reproduce the issue for them.
Note that two of the components, checkbox and toggle, had to have special implementations for both their test and fix because of how the host component acts as the component for accessibility purposes.
Current dev build:
8.5.7-dev.11746044124.147aab6c